| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Andres Freund <andres(at)2ndquadrant(dot)com> |
| Cc: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Andrew Dunstan <andrew(at)dunslane(dot)net>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: jsonb is also breaking the rule against nameless unions |
| Date: | 2014-04-02 19:03:47 |
| Message-ID: | 6882.1396465427@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Andres Freund <andres(at)2ndquadrant(dot)com> writes:
> On 2014-04-02 14:36:28 -0400, Tom Lane wrote:
>> Well, in any case, people very seldom check to see if any buildfarm
>> members are producing compiler warnings. You need the build to actually
>> go red to get anyone's attention reliably.
> Yea, we'd need to be able to turn on -Werror if it's going to have any
> effect. I don't think our configure currently copes with that
> unfortunately...
I'm pretty sure you can set CFLAGS from the buildfarm configuration
options --- see the animals that are building with -DCLOBBER_CACHE_ALWAYS.
> I just tried it on clang. It builds clean with -Wc11-extensions except
> warning about _Static_assert(). That's possibly fixable with some
> autoconf trickery.
Ah. That sounds promising. What clang version is that?
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2014-04-02 19:21:26 | Re: jsonb is also breaking the rule against nameless unions |
| Previous Message | Andres Freund | 2014-04-02 18:43:20 | Re: jsonb is also breaking the rule against nameless unions |