Re: Should the function get_variable_numdistinct consider the case when stanullfrac is 1.0?

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Zhenghua Lyu <zlyu(at)vmware(dot)com>
Cc: "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Should the function get_variable_numdistinct consider the case when stanullfrac is 1.0?
Date: 2020-10-26 14:37:06
Message-ID: 685722.1603723026@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Zhenghua Lyu <zlyu(at)vmware(dot)com> writes:
> It seems the function `get_variable_numdistinct` ignore the case when stanullfrac is 1.0:

I don't like this patch at all. What's the argument for having a special
case for this value? When would we ever get exactly 1.0 in practice?

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message David G. Johnston 2020-10-26 14:53:43 Re: Additional Chapter for Tutorial
Previous Message Tom Lane 2020-10-26 14:35:32 Re: default result formats setting