| From: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
|---|---|
| To: | Dave Cramer <davecramer(at)gmail(dot)com> |
| Cc: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Petr Jelinek <petr(at)2ndquadrant(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Michael Paquier <michael(at)paquier(dot)xyz>, Dmitry Dolgov <9erthalion6(at)gmail(dot)com>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, Petr Jelinek <petr(dot)jelinek(at)2ndquadrant(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Binary support for pgoutput plugin |
| Date: | 2020-07-06 13:03:32 |
| Message-ID: | 68414442-40C5-45E0-82D0-88CC1A383A03@yesql.se |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> On 6 Jul 2020, at 14:58, Dave Cramer <davecramer(at)gmail(dot)com> wrote:
> as far as rebase -i do what is advised here for squashing them. Just one patch now ?
One patch per logical change, if there are two disjoint changes in the patchset
where one builds on top of the other then multiple patches are of course fine.
My personal rule-of-thumb is to split it the way I envision it committed.
cheers ./daniel
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Fujii Masao | 2020-07-06 13:16:18 | Re: Is it useful to record whether plans are generic or custom? |
| Previous Message | Dave Cramer | 2020-07-06 12:58:01 | Re: Binary support for pgoutput plugin |