| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
| Cc: | PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [COMMITTERS] pgsql: Allow multiple tables to be specified in one VACUUM or ANALYZE c |
| Date: | 2017-10-05 14:52:27 |
| Message-ID: | 6841.1507215147@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
Michael Paquier <michael(dot)paquier(at)gmail(dot)com> writes:
> Tom, it seems to me that in the portions you have editorialized, you
> have forgotten to update two comments still mentioning get_rel_oids()
> in vacuum.c and analyze.c. Those should now refer to
> expand_vacuum_rel() instead. Please see the attached.
Oh, good point. I don't think that just s/get_rel_oids/expand_vacuum_rel/
will do though, as it leaves out the interaction with get_all_vacuum_rels.
I decided that the point was of merely historical interest anyway, and
just removed the reference to the other routine.
The partitioned-table patches seem to have been a bit sloppy with
maintaining these comments too, so I ended up doing more than that...
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2017-10-05 15:43:48 | pgsql: Allow DML commands that create tables to use parallel query. |
| Previous Message | Tom Lane | 2017-10-05 14:47:52 | pgsql: Improve comments in vacuum_rel() and analyze_rel(). |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2017-10-05 14:57:00 | Re: postgres_fdw bug in 9.6 |
| Previous Message | Robert Haas | 2017-10-05 14:45:52 | Re: Proposal: Improve bitmap costing for lossy pages |