Re: work in progress: timestamp patch

On 26-Jul-05, at 1:23 AM, Oliver Jowett wrote:

> Dave Cramer wrote:
>
>
>> I've been messing with it a bit myself, and noticed that
>> TimeStampUtils.toString used the timezone of the incoming
>> timestamp, not the calendar. So the call to appendTimeZone, passes in
>> the timestamp, not the new calendar.
>>
>
> I looked at this and the current code is certainly wrong. The timezone
> offset of a Timestamp (deprecated method!) returns the offset of the
> JVM's default timezone always. We should indeed be passing the target
> calendar and using that.
>
> I've added that change to my patch. Interestingly none of the
> regression
> tests fail with it changed; we're very short on tests that actually
> test
> the with-Calendar code..
Well, I actually think this little change is more of the problem than
anything else.
The reason it doesn't fail is because the timezone of the server and
the client are the same.

Did you manage to cobble together a patch for me to test ?

>
> -O
>
> ---------------------------(end of
> broadcast)---------------------------
> TIP 5: don't forget to increase your free space map settings
>
>