Re: [PATCH] Cleanup of GUC units code

-----BEGIN PGP SIGNED MESSAGE-----
Hash: RIPEMD160

> You do realize that misspelling unit name can cause downtime of several
> minutes instead of couple seconds? We can easily do restart in couple of
> seconds but the restart, look logs, launch editor, find value, change,
> save, restart cycle will take quite a lot more. Why should we increase
> the chance that any config edit causes problems?

Minutes? It's like any other changes made to postgresql.conf: make the change,
ctrl-z out of your editor, reload Postgres. If there's an error, foreground
to the editor, revert the change, and reload Postgres. Not ideal (the
config file checker is what we really want), but certainly quick.

> Secondly, humans don't have byte-exact memory, instead they generalize
> and deduce (eg. from nearby parameters). Thus remembering "KB, MB, GB"
> or "kb, mb, gb" is easier than remembering "kB, MB, GB".

They are all listed at the top of the file, in case there is any confusion.
No need to worry about remembering things.

- --
Greg Sabino Mullane greg(at)turnstep(dot)com
PGP Key: 0x14964AC8 200809031501
http://biglumber.com/x/web?pk=2529DF6AB8F79407E94445B4BC9B906714964AC8
-----BEGIN PGP SIGNATURE-----

iEYEAREDAAYFAki+39gACgkQvJuQZxSWSsiTfACgiNPP77YKGKgyBm36ckkKZhGM
b9sAn2JmrpbMkJ8dm0Wbz3TYdLo83h/S
=PQvy
-----END PGP SIGNATURE-----