| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Greg Stark <stark(at)mit(dot)edu> |
| Cc: | Merlin Moncure <mmoncure(at)gmail(dot)com>, Kevin Grittner <Kevin(dot)Grittner(at)wicourts(dot)gov>, Dan Ports <drkp(at)csail(dot)mit(dot)edu>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Coding style point: "const" in function parameter declarations |
| Date: | 2011-06-23 00:01:20 |
| Message-ID: | 6767.1308787280@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Greg Stark <stark(at)mit(dot)edu> writes:
> On Wed, Jun 22, 2011 at 5:41 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> If we were thinking of moving in that direction, I would argue that
>> we should get rid of typedef'd pointers altogether, ie, change
>> "Relation" to be a typedef for the struct and write "Relation *rel"
>> not "Relation rel".
> Hm. I have to say the single most confusing thing about the Postgres
> source that took me a *long* time to get over was remembering that
> some of the typedefs were already pointers and some weren't.
Yeah, the lack of consistency about that is annoying.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Geoghegan | 2011-06-23 00:06:43 | Re: Coding style point: "const" in function parameter declarations |
| Previous Message | Greg Stark | 2011-06-22 23:37:24 | Re: Coding style point: "const" in function parameter declarations |