Re: [PATCH] Add support for displaying database service in psql prompt

Hi,

On Tue, Dec 17, 2024 at 04:43:21PM +0900, Michael Paquier wrote:
> On Mon, Dec 16, 2024 at 10:57:49PM +0100, Michael Banck wrote:
> > Thanks, I have added the documentation now in v2.
>
> The doc additions seem fine to me. I've just grabbed three tiny nits,
> nothing critical.

Thanks for the further review.

> + case 's':
> + if (PQservice(pset.db))
> + strlcpy(buf, PQservice(pset.db), sizeof(buf));
> + break;
>
> Other code paths of get_prompt check for pset.db being NULL. True
> that it does not matter when calling PQservice() with a connection
> that does not exist. For consistency with the surroundings this
> should be done at least?

Ok, I've done that.

>
> + <para>
> + The service from <filename>pg_service.conf</filename>, if applicable.
> + </para>
>
> pg_service.conf is not especially true as it depends on the
> environment used. For psql, perhaps just use "The service name, if
> applicable". No need to be fancy.

Done.

> + <varlistentry id="app-psql-prompting-s">
> + <term><literal>%s</literal></term>
> + <listitem><para>The name of the service entry, if any.</para></listitem>
> + </varlistentry>
>
> Other entries don't use "if any", would just cut it.

Done.

V3 attached.

Michael