| From: | Michael Banck <mbanck(at)gmx(dot)net> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Greg Sabino Mullane <htamfids(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: [PATCH] Add support for displaying database service in psql prompt |
| Date: | 2024-12-16 21:57:49 |
| Message-ID: | 6760a25e.a70a0220.2e9d8f.d542@mx.google.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi Michael,
On Tue, Dec 10, 2024 at 04:38:24PM +0900, Michael Paquier wrote:
> On Thu, Nov 28, 2024 at 09:17:23PM +0100, Michael Banck wrote:
> > On Tue, Nov 19, 2024 at 07:47:58PM -0500, Greg Sabino Mullane wrote:
> > > Compiled and tested: works fine, so +1 from me. Honestly, I was surprised
> > > %s was still available. :)
> >
> > Thanks. Was that full review? You kept the commitfest item in "Needs
> > Review" state.
>
> No objections to this proposal, that can be useful. No objections
> with the use of 's' for the shortcut in the psql prompt.
Cool.
> Back to your patch, you are missing two things at quick glance:
> - Documentation for the new libpq API in 0001.
> - Documentation for the new SERVICE and its new %s (see section called
> "Prompting" on the psql page.
>
> So please make sure to provide these with the next version of the
> patch.
Thanks, I have added the documentation now in v2.
Michael
| Attachment | Content-Type | Size |
|---|---|---|
| v2-0001-Add-PQservice-to-PGConn.patch | text/x-diff | 3.9 KB |
| v2-0002-Add-support-for-database-service-to-psql-prompt.patch | text/x-diff | 3.2 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Nathan Bossart | 2024-12-16 22:02:56 | Re: Track the amount of time waiting due to cost_delay |
| Previous Message | Nathan Bossart | 2024-12-16 21:56:42 | Re: A few patches to clarify snapshot management |