Re: stats.sql fails during installcheck on mac

Sami Imseih <samimseih(at)gmail(dot)com> writes:
> When running "make installcheck" on my mac, I ran into a failure:

> @@ -1459,7 +1459,7 @@
> OR :io_sum_wal_normal_after_fsyncs > :io_sum_wal_normal_before_fsyncs;
> ?column?
> ----------
> - t
> + f
> (1 row)

Hmm, that's a little nasty, because it's not showing up in the
buildfarm. It appears from a little testing that the issue only
manifests if you have fsync = on, which we generally don't on
buildfarm animals.

That concerns me independently of this specific failure, because
it calls into question how realistic our testing of things like
fsync statistics really is.

Anyway, back to the patch: there are multiple places in
stats.sql that are effectively disabling tests if fsync = off,
not only this one. Why does only this one need the exception?
Should we be rethinking or tightening some of the others?

regards, tom lane