From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | Andres Freund <andres(at)anarazel(dot)de> |
Cc: | pgsql-hackers(at)postgresql(dot)org, pgsql-committers(at)postgresql(dot)org |
Subject: | Re: [HACKERS] pgsql: Add port/strnlen support to libpq and ecpg Makefiles. |
Date: | 2017-10-12 17:03:59 |
Message-ID: | 673.1507827839@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers pgsql-hackers |
I wrote:
> On reflection, let's just go with the solution of building libpgport_lib.a
> with the right flags (fPIC + threading) and leave libpgport.a alone.
> That way we don't need a debate about whether there's an efficiency
> cost worth worrying about.
I looked into this and got discouraged after realizing that not only does
libpq pull in and recompile a bundle of src/port/ files, but also from
src/common/, and even some random backend files like encnames.c and
wchar.c. We could possibly apply the same build-a-third-way technique to
src/common/, but we'd still end up with messiness for the encoding files.
Perhaps what this is telling us is that encnames.c and wchar.c ought to be
moved to src/common/.
On top of that, there are also some interactions with the MSVC build
system that I don't especially want to debug or untangle.
In short, this is looking like a whole lot more work than we could
ever hope to save by not having to maintain these file lists anymore.
So I'm not planning to pursue it. If someone else wants to, though,
have at it.
regards, tom lane
From | Date | Subject | |
---|---|---|---|
Next Message | Andres Freund | 2017-10-12 17:45:44 | Re: pgsql: Add configure infrastructure to detect support for C99's restric |
Previous Message | Tom Lane | 2017-10-12 15:36:29 | pgsql: Doc: fix typo in release notes. |
From | Date | Subject | |
---|---|---|---|
Next Message | Gourav Kumar | 2017-10-12 17:17:14 | Re: How does postgres store the join predicate for a relation in a given query |
Previous Message | Tom Lane | 2017-10-12 16:38:36 | Re: How does postgres store the join predicate for a relation in a given query |