Re: extension_control_path and "directory"

From: "David E(dot) Wheeler" <david(at)justatheory(dot)com>
To: Matheus Alcantara <matheusssilv97(at)gmail(dot)com>
Cc: Christoph Berg <myon(at)debian(dot)org>, Peter Eisentraut <peter(at)eisentraut(dot)org>, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: extension_control_path and "directory"
Date: 2025-04-25 19:13:02
Message-ID: 672C8C5E-519A-4B39-9421-E6C31917B271@justatheory.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

On Apr 25, 2025, at 09:25, Matheus Alcantara <matheusssilv97(at)gmail(dot)com> wrote:

> Yes, you are right. The problem was where I was asserting
> control->control_dir != NULL. I've moved the assert after the "if
> (!filename)" check that returns an error if the extension was not found.
>
> Attached v3 with this fix and also a TAP test for this scenario.

That fixes the segfault, thank you.

> I'm just a bit confused how you get it working using /extension at the
> end of extension_control_path since with this patch this suffix is not
> necessary and since we hard coded append this it should return an error
> when trying to search on something like

It worked with

extension_control_path = '/Users/david/Downloads/share/postgresql/extension:$system’

But not with

extension_control_path = '/Users/david/Downloads/share/postgresql:$system’

And here is where the control file actually is:

❯ ll ~/Downloads/share/postgresql/extension total 8
-rw-r--r-- 1 david staff 161B Apr 24 18:07 semver.control

So I don’t know the answer to your question, but it’d be handy to have functions that return a list of resolved paths from extension_control_path and dynamic_library_path, since they get mangled.

Best,

David

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Matheus Alcantara 2025-04-25 21:18:58 Re: extension_control_path and "directory"
Previous Message Andres Freund 2025-04-25 17:35:03 pgsql: Fix bug allowing io_combine_limit > io_max_combine_combine limit

Browse pgsql-hackers by date

  From Date Subject
Next Message David E. Wheeler 2025-04-25 19:23:47 Re: RFC: Additional Directory for Extensions
Previous Message Jacob Champion 2025-04-25 18:56:38 Re: sslmode=secure by default (Re: Making sslrootcert=system work on Windows psql)