Re: pg_upgrade < 9.3 -> >=9.3 misses a step around multixacts

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Andres Freund <andres(at)2ndquadrant(dot)com>
Cc: Bruce Momjian <bruce(at)momjian(dot)us>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, PostgreSQL Bugs <pgsql-bugs(at)postgresql(dot)org>
Subject: Re: pg_upgrade < 9.3 -> >=9.3 misses a step around multixacts
Date: 2014-07-21 17:17:25
Message-ID: 6720.1405963045@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs

Andres Freund <andres(at)2ndquadrant(dot)com> writes:
> On 2014-07-21 13:03:21 -0400, Tom Lane wrote:
>> I don't see any point in being picky about it. What we want is to reject
>> values that are conclusively bogus; things that are just close to bogus
>> are not so interesting.

> It'd just have been about optimizing away repeated calls to ReadNew*...

Oh. I think the existing code is probably efficient enough about that.
vac_update_datfrozenxid() only does it once anyway, and the calls in
vac_update_relstats() are arranged so that we don't expect them to be hit
at all in normal cases.

regards, tom lane

In response to

Browse pgsql-bugs by date

  From Date Subject
Next Message dgillis 2014-07-21 19:49:18 BUG #11014: Postgres can be put into an error state by setting invalid timezone.
Previous Message Andres Freund 2014-07-21 17:09:53 Re: pg_upgrade < 9.3 -> >=9.3 misses a step around multixacts