Re: [COMMITTERS] pgsql: Sequences were not being shown due to the use of lowercase `s`

From: "Greg Sabino Mullane" <greg(at)turnstep(dot)com>
To: pgsql-hackers(at)postgresql(dot)org
Subject: Re: [COMMITTERS] pgsql: Sequences were not being shown due to the use of lowercase `s`
Date: 2006-09-04 22:36:47
Message-ID: 66ff0cbe1bf948aed11d09e77cc7d62e@biglumber.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

I wrote:
> Sequences were not being shown due to the use of lowercase 's' instead
> of 'S', and the views were not checking for table visibility with
> regards to temporary tables and sequences.

Tom Lane replied:
>> What became of my objection that the test should be on USAGE privilege
>> for the containing schema instead?

I took a stab at implementing this, but what exactly would we check? Looks
like all the temp tables have automatic usage for the same user, according to

SELECT *,has_schema_privilege(oid,'USAGE') FROM pg_namespace;

So I'd need another way to test that the schema was created by another process.
I agree that is_visible may not be ideal for most cases, but it should be okay
if we are simply using it to filter temporary schemas, right?

- --
Greg Sabino Mullane greg(at)turnstep(dot)com
End Point Corporation
PGP Key: 0x14964AC8 200609041803
http://biglumber.com/x/web?pk=2529DF6AB8F79407E94445B4BC9B906714964AC8
-----BEGIN PGP SIGNATURE-----

iD8DBQFE/Km6vJuQZxSWSsgRAgkaAKC/Nzc8xIcxRC1TW2UJCB76LurWmgCg+Dkk
4HbMsy4H1uwRAUz9lqCSdXg=
=eBg2
-----END PGP SIGNATURE-----

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2006-09-04 22:41:06 Re: [COMMITTERS] pgsql: sslinfo contrib module - information about current SSL
Previous Message Alvaro Herrera 2006-09-04 22:22:44 Re: [COMMITTERS] pgsql: sslinfo contrib module - information about current SSL

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2006-09-04 22:41:06 Re: [COMMITTERS] pgsql: sslinfo contrib module - information about current SSL
Previous Message Alvaro Herrera 2006-09-04 22:22:44 Re: [COMMITTERS] pgsql: sslinfo contrib module - information about current SSL