Re: pgsql: Add support for ICU 4.2

From: Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>
To: Peter Geoghegan <pg(at)bowt(dot)ie>
Cc: pgsql-committers <pgsql-committers(at)postgresql(dot)org>
Subject: Re: pgsql: Add support for ICU 4.2
Date: 2017-08-07 13:51:16
Message-ID: 66eb0666-3ed7-560f-caa5-28d68041265b@2ndquadrant.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

On 8/6/17 20:40, Peter Geoghegan wrote:
> On Sat, Aug 5, 2017 at 6:36 AM, Peter Eisentraut <peter_e(at)gmx(dot)net> wrote:
>> In ICU 4.2, ucol_getKeywordsForLocale() sometimes returns values that
>> will not be accepted by uloc_toLanguageTag(). Skip loading keyword
>> variants in that version.
>
> This should be spelled ucol_getKeywordValuesForLocale() in both the
> commit message and the code comment. There is no
> ucol_getKeywordsForLocale() function.

Fixed, thanks.

--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Heikki Linnakangas 2017-08-07 14:08:04 pgsql: Don't allow logging in with empty password.
Previous Message Peter Eisentraut 2017-08-07 13:50:33 pgsql: Fix function name in code comment