From: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
---|---|
To: | Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> |
Cc: | Tofig Aliev <t(dot)aliev(at)postgrespro(dot)ru>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
Subject: | Re: Fix tiny memory leaks |
Date: | 2024-12-09 19:03:09 |
Message-ID: | 66C551B8-1E5B-478E-81BC-2E224DB096F3@yesql.se |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
> On 9 Dec 2024, at 19:52, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> wrote:
>
> On Fri, Dec 6, 2024 at 12:49 AM Daniel Gustafsson <daniel(at)yesql(dot)se> wrote:
>>
>>> On 6 Dec 2024, at 09:38, Tofig Aliev <t(dot)aliev(at)postgrespro(dot)ru> wrote:
>>
>>> There is a memory leak in functions check_application_name() and check_cluster_name().
>>> Functions are located in src/backend/commands/variable.c
>>
>> LGTM.
>
> LGTM. It seems commit a9d58bfe8a3a missed to fix this memory leak.
Yeah. While fairly insignificant in nature, and there has been no complaints
until now, I'm preparing a backpatch down to REL_15_STABLE to keep the code in
sync for other backpatches to apply clean.
--
Daniel Gustafsson
From | Date | Subject | |
---|---|---|---|
Next Message | Nathan Bossart | 2024-12-09 19:16:38 | unused-but-set-variable warning on REL_13_STABLE |
Previous Message | Masahiko Sawada | 2024-12-09 18:52:18 | Re: Fix tiny memory leaks |