Re: Patching dblink.c to avoid warning about open transaction

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Jonathan Beit-Aharon <jbeitaharon(at)intrusic(dot)com>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: Patching dblink.c to avoid warning about open transaction
Date: 2005-09-23 21:31:37
Message-ID: 6686.1127511097@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

Jonathan Beit-Aharon <jbeitaharon(at)intrusic(dot)com> writes:
> &nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; if (!conn)<br>
> &nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; DBLINK_CONN_NOT_AVAIL;<br>
> +<br>
> +&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; if (rcon)<br>
> +&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; rcon-&gt;remoteTrFlag = (PQtransactionStatus(conn) !=
> PQTRANS_IDLE);<br>
> <br>
> -&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; res = PQexec(conn, "BEGIN");<br>
> -&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; if (PQresultStatus(res) != PGRES_COMMAND_OK)<br>
>
> [etc]

Could we see this in a less broken format?

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 2005-09-23 21:34:47 Re: ALTER ROLES - questions
Previous Message Dann Corbit 2005-09-23 21:20:39 Re: [PERFORM] Releasing memory during External sorting?

Browse pgsql-patches by date

  From Date Subject
Next Message Bruce Momjian 2005-09-23 21:39:15 Re: Patching dblink.c to avoid warning about open transaction
Previous Message Bruce Momjian 2005-09-23 21:03:02 Re: PL/Python error checking