| From: | Ilia Evdokimov <ilya(dot)evdokimov(at)tantorlabs(dot)com> |
|---|---|
| To: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Removing unused parameter in compute_expr_stats |
| Date: | 2024-12-26 09:40:52 |
| Message-ID: | 667b92d2-f953-4fcb-9377-3765f5b94187@tantorlabs.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi hackers,
I'm sharing a small patch that removes an unused parameter (totalrows)
from compute_expr_stats function in extended_stats.c .
This function originally appeared in commit
a4d75c86bf15220df22de0a92c819ecef9db3849, which introduced extended
statistics on expressions. From what I can see, total rows is never used
in the current implementation, so this patch removes it
If there are reasons to keep this parameter, or if there's anything I
might have missed, I'd be happy to discuss further.
--
Best regards,
Ilia Evdokimov,
Tantor Labs LLC.
| Attachment | Content-Type | Size |
|---|---|---|
| v1-0001-Remove-unused-parameter-in-compute_expr_stats.patch | text/x-patch | 2.2 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Yura Sokolov | 2024-12-26 10:10:59 | Bug in v13 due to "Fix corruption when relation truncation fails." |
| Previous Message | Zhijie Hou (Fujitsu) | 2024-12-26 06:02:20 | RE: Introduce XID age and inactive timeout based replication slot invalidation |