Re: Fix around conn_duration in pgbench

From: Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com>
To: Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>, Yugo NAGATA <nagata(at)sraoss(dot)co(dot)jp>
Cc: Tatsuo Ishii <ishii(at)sraoss(dot)co(dot)jp>, asifr(dot)rehman(at)gmail(dot)com, PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Fix around conn_duration in pgbench
Date: 2021-08-31 16:10:37
Message-ID: 6614fa41-3c23-5563-e931-e287cd64f960@oss.nttdata.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2021/08/31 16:56, Fabien COELHO wrote:
>
>>> I would think we should leave as it is for pg13 and before to not surprise users.
>>
>> Ok. Thank you for your opinion. I also agree with not changing the behavior of
>> long-stable branches, and I think this is the same opinion as Fujii-san.
>>
>> Attached is the patch to fix to measure disconnection delays that can be applied to
>> pg14 or later.
>
> I agree that this is not a bug fix, so this is not a matter suitable for for backpatching. Maybe for pg14.

+1. So we reached the consensus!

Attached is the updated version of the patch. Based on Nagata-san's latest patch,
I just modified the comment slightly and ran pgindent. Barring any objection,
I will commit this patch only in master and v14.

Regards,

--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION

Attachment Content-Type Size
pgbench-conn-duration-pg14-7.patch text/plain 1.8 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Eisentraut 2021-08-31 16:52:52 Re: [PATCH] pg_permissions
Previous Message Andres Freund 2021-08-31 15:53:33 Re: prevent immature WAL streaming