Re: Removing pgsql_tmp files

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Alvaro Herrera <alvherre(at)commandprompt(dot)com>
Cc: Michael Glaesemann <michael(dot)glaesemann(at)myyearbook(dot)com>, pgsql-general <pgsql-general(at)postgresql(dot)org>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Removing pgsql_tmp files
Date: 2010-11-09 02:46:28
Message-ID: 6604.1289270788@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-general pgsql-hackers

Alvaro Herrera <alvherre(at)commandprompt(dot)com> writes:
> Excerpts from Tom Lane's message of lun nov 08 22:29:28 -0300 2010:
>> I think we need to re-order the operations there to ensure that the
>> unlink will still happen if the ereport gets interrupted.

> Would it work to put the removal inside a PG_CATCH block?

Well, that still begs the question of what to do exactly. After some
thought I believe the attached is the best fix.

regards, tom lane

Attachment Content-Type Size
fix-temp-file-unlink.patch text/x-patch 2.6 KB

In response to

Browse pgsql-general by date

  From Date Subject
Next Message Ralph Smith 2010-11-09 04:11:23 I guess I'm missing something here WRT FOUND
Previous Message Dave Page 2010-11-09 02:21:17 Re: One-click Installers for 9.1 Alpha 2 (ETA)

Browse pgsql-hackers by date

  From Date Subject
Next Message Itagaki Takahiro 2010-11-09 02:52:05 Re: patch: Add JSON datatype to PostgreSQL (GSoC, WIP)
Previous Message Itagaki Takahiro 2010-11-09 02:27:26 Re: Complier warnings on mingw gcc 4.5.0