Re: Problems with extended-Query logging code

From: Dave Cramer <pg(at)fastcrypt(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-hackers(at)postgreSQL(dot)org
Subject: Re: Problems with extended-Query logging code
Date: 2006-09-06 22:22:45
Message-ID: 659C4A44-0269-40DE-AA84-E344C92E8F62@fastcrypt.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers


On 6-Sep-06, at 6:17 PM, Tom Lane wrote:

> Dave Cramer <pg(at)fastcrypt(dot)com> writes:
>> On 6-Sep-06, at 6:01 PM, Tom Lane wrote:
>>> * It doesn't log the values of parameters sent in binary mode, which
>>> is something that at least JDBC needs.
>
>> AFAIK, we don't need binary mode right away, currently we only send
>> bytea parameters in binary mode
>
> I thought somebody had mentioned that integers were also sent in
> binary
> in the latest driver code? Can't find the archive entry right now
> though.
>
> regards, tom lane
>
Checking the source code

boolean isBinary(int index) {
// Currently, only StreamWrapper uses the binary parameter
form.
return (paramValues[index -1] instanceof StreamWrapper);
}

So for now if we concentrate on text parameters, binary parameters
would be superfluous for the moment.

Dave

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 2006-09-06 22:28:37 Re: Problems with extended-Query logging code
Previous Message Michael Fuhr 2006-09-06 22:22:15 Re: ECPG/OpenBSD buildfarm failures, take I