From: | "Gurjeet Singh" <singh(dot)gurjeet(at)gmail(dot)com> |
---|---|
To: | "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | "Bruce Momjian" <pgman(at)candle(dot)pha(dot)pa(dot)us>, "PGSQL Hackers" <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: error in compilation! |
Date: | 2006-05-28 02:16:49 |
Message-ID: | 65937bea0605271916u3ae68733wf9af175e86ac38e7@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Confirmation: The patch rollback in src/pl/plpgsql/src/gram.y resolved
the issue.
On 5/28/06, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> I wrote:
> > Currently looking through the rest of the patch. I'm wondering
> > about appendStringLiteral: maybe we should kill that entirely
> > in favor of using PQescapeStringConn? It's not nearly bright
> > enough about encoding for instance (and it *will* be used in
> > client-only encodings).
>
> We could make an appendStringLiteralConn, which would do this correctly
> for most of the utility programs. However there's a problem for
> pg_restore: it doesn't necessarily have a PGconn at all. (Consider
> the case of pg_restore producing text output.)
>
> It seems that the alternatives are to export PQescapeStringInternal
> from libpq, or to duplicate its functionality in appendStringLiteral.
> Don't much like either, but perhaps the second is less bad. Any
> opinions?
>
> regards, tom lane
>
> ---------------------------(end of broadcast)---------------------------
> TIP 9: In versions below 8.0, the planner will ignore your desire to
> choose an index scan if your joining column's datatypes do not
> match
>
From | Date | Subject | |
---|---|---|---|
Next Message | Bruce Momjian | 2006-05-28 02:42:11 | Re: error in compilation! |
Previous Message | Andrew Dunstan | 2006-05-28 02:08:06 | Re: osprey buildfarm member has been failing for a long while |