From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
Cc: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: pgindent vs dtrace on macos |
Date: | 2020-09-17 00:34:55 |
Message-ID: | 65902.1600302895@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
I wrote:
> Daniel Gustafsson <daniel(at)yesql(dot)se> writes:
>> The attached patch fixes the generation of sql_help.h and perl_opmask.h to make
>> sure they conform to pgindent. Those were the only file I got diffs in after a
>> pgindent run apart from fmgrprotos.h which gave the below:
> Hmm, I seem to recall there were more when this happened to me back in
> May. But in any case, fixing these is an improvement.
Experimenting with this patch soon found one additional case: sql_help.c,
also emitted by create_help.pl, also needs some whitespace help.
I do not recall if there are other places, but fixing these is
surely a step forward. I fixed the sql_help.c output and pushed it.
regards, tom lane
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2020-09-17 00:36:55 | Re: Gripes about walsender command processing |
Previous Message | Alvaro Herrera | 2020-09-17 00:19:26 | Re: Gripes about walsender command processing |