Re: [subxacts] Fixing TODO items

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Alvaro Herrera <alvherre(at)dcc(dot)uchile(dot)cl>
Cc: Patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: [subxacts] Fixing TODO items
Date: 2004-07-27 17:32:01
Message-ID: 656.1090949521@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

Alvaro Herrera <alvherre(at)dcc(dot)uchile(dot)cl> writes:
> There are some likely controversial changes; the Xid caches, in the
> first place.

No kidding ;-)

Do you have any theoretical or practical evidence for the usefulness of
the negxids cache? Seems to me the shared memory space would be better
spent on allowing deeper nesting of the running-subxids list. Also,
what happened to marking whether the running-subxids list has
overflowed? If none of them have then there's no need to wonder whether
we have a still-running subxact.

The apparent lack of any locking on these data structures seems wrong
too.

regards, tom lane

In response to

Responses

Browse pgsql-patches by date

  From Date Subject
Next Message Tom Lane 2004-07-27 18:06:58 Re: [subxacts] Fixing TODO items
Previous Message Tom Lane 2004-07-27 16:49:10 Re: [subxacts] Fixing TODO items