Re: Subtle bug in autoconf flex version test

From: Daniel Gustafsson <daniel(at)yesql(dot)se>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Subtle bug in autoconf flex version test
Date: 2016-05-02 13:42:01
Message-ID: 65577F12-8F04-4082-A89A-27ED1F3B690A@yesql.se
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> On 02 May 2016, at 15:38, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>
> Daniel Gustafsson <daniel(at)yesql(dot)se> writes:
>> The PGAC_PATH_FLEX version test in config/programs.m4 tests the major and minor
>> versions with = rather than == which unless I’m missing something is performing
>> assignment rather than testing equality?
>
> Huh. That's been broken since forever ... thanks for noticing!
>
>> The attached diff makes the test
>> trigger the expected warning on major/minor version on my OS X box (awk version
>> 20070501).
>
> Hm, is that a popular flex version? I wonder whether we will get
> complaints if we start warning about it.

Sorry, I missed half the sentence there. What I meant was that I can trigger
the warning synthetically by changing the version number just to test the
warning; before any version is happily accepted.

cheers ./daniel

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Alvaro Herrera 2016-05-02 13:47:39 Re: Timeline following for logical slots
Previous Message Robert Haas 2016-05-02 13:41:12 Re: Timeline following for logical slots