From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | Amit Langote <amitlangote09(at)gmail(dot)com> |
Cc: | Andrew Dunstan <andrew(at)dunslane(dot)net>, pgsql-committers(at)lists(dot)postgresql(dot)org |
Subject: | Re: pgsql: Add basic JSON_TABLE() functionality |
Date: | 2024-04-04 16:55:08 |
Message-ID: | 655689.1712249708@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
I wrote:
> We need to either nuke that ecpg warning entirely, or find a more
> robust way of detecting whether the gram.y complaint is conditional.
> I'll put a brown paper bag on my head before suggesting that maybe
> we could pay attention to how far the errcode is indented. Perhaps
> a slightly nicer way is to assume it's conditional if any earlier
> line in the rule starts with "if".
The latter seems considerably safer, so I modified parse.pl along
those lines. Eyeball comparison of gram.y with preproc.y verifies
that now ecpg will emit the warning only in rules where the backend
unconditionally reports FEATURE_NOT_SUPPORTED.
I suppose this needs to be back-patched.
regards, tom lane
Attachment | Content-Type | Size |
---|---|---|
suppress-inappropriate-ecpg-warnings.patch | text/x-diff | 1.9 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2024-04-04 17:21:40 | pgsql: Further cleanup for recent JSON-related commits. |
Previous Message | Andrew Dunstan | 2024-04-04 16:45:14 | pgsql: Tidy up after incremental JSON parser patch |