| From: | Célestin Matte <celestin(dot)matte(at)cmatte(dot)me> |
|---|---|
| To: | Magnus Hagander <magnus(at)hagander(dot)net> |
| Cc: | PostgreSQL WWW <pgsql-www(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: pgarchives: Bug report + Patches: loader can't handle message in multiple lists |
| Date: | 2023-06-05 13:39:25 |
| Message-ID: | 652946e1-1218-bf29-705f-f5f9302128e5@cmatte.me |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-www |
> How does it even get that far? The code on line 32 of storage.py will
> check if the message is already in the archives. How does it even get
> to the point of trying to insert the message again?
Because my patch bypasses this by checking whether the message exists *in the given list*
This was the beginning of an attempt to fix a crash I had. As far as I remember, the crash was that the message already existed.
But as said in previous email, this was not sufficient to solve the issue.
> I'm not sure I like the idea of committing after every message and
> then rolling back in the event of an error. If nothing else, this
> should be done using a savepoint instead of a complete transaction.
Attached
--
Célestin Matte
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-load_message-catch-postgres-UniqueViolation-errors-w.patch | text/x-patch | 1.5 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bobby R. Ward | 2023-06-06 14:34:37 | Broken slack links |
| Previous Message | Zheng Li | 2023-06-05 04:30:45 | Wiki editor access request |