| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
| Cc: | Dagfinn Ilmari Mannsåker <ilmari(at)ilmari(dot)org>, Peter Smith <smithpb2250(at)gmail(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: pg_createsubscriber TAP test wrapping makes command options hard to read. |
| Date: | 2024-12-12 15:35:15 |
| Message-ID: | 651128.1734017715@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Andrew Dunstan <andrew(at)dunslane(dot)net> writes:
> On 2024-12-12 Th 8:17 AM, Dagfinn Ilmari Mannsåker wrote:
>> Here's a more thorough patch, that also applies the fat comma treatment
>> to other pg_createsubscriber invocations in the same file that don't
>> currently happen to be mangled by perltidy. It also adds trailing
>> commas to the last item in multi-line command arrays, which is common
>> perl style.
> +1 for this approach.
Indeed, this is much nicer if it's something perltidy knows about.
However, I know we have the same issue in many other places.
Anyone feel like running through all the TAP scripts?
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2024-12-12 15:45:29 | Re: Proposal for Updating CRC32C with AVX-512 Algorithm. |
| Previous Message | Alvaro Herrera | 2024-12-12 15:29:47 | Re: .ready and .done files considered harmful |