From: | Andrew Dunstan <andrew(dot)dunstan(at)2ndquadrant(dot)com> |
---|---|
To: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
Cc: | Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com> |
Subject: | lowering pg_regress privileges on Windows |
Date: | 2018-10-18 12:31:11 |
Message-ID: | 650b0c29-9578-8571-b1d2-550d7f89f307@2ndQuadrant.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
From the "scratch a long running itch" department.
The attached ridiculously tiny patch solves the problem whereby while we
can run Postgres on Windows safely from an Administrator account, we
can't run run the regression tests from the same account, since it fails
on the tablespace test, the tablespace directory having been set up
without first having lowered privileges. The solution is to lower
pg_regress' privileges in the same way that we do with other binaries.
This is useful in setups like Appveyor where running under any other
account is ... difficult. For the cfbot Thomas has had to make the
script hack the schedule file to omit the tablespace test. This would
make that redundant.
I propose to backpatch this. It's close enough to a bug and the risk is
almost infinitely small.
cheers
andrew
--
Andrew Dunstan https://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
Attachment | Content-Type | Size |
---|---|---|
regress_restricted.patch | text/x-patch | 474 bytes |
From | Date | Subject | |
---|---|---|---|
Next Message | Alexander Kuzmenkov | 2018-10-18 12:47:09 | Re: Removing unneeded self joins |
Previous Message | Thomas Munro | 2018-10-18 09:03:10 | Re: DSM robustness failure (was Re: Peripatus/failures) |