| From: | Chapman Flack <chap(at)anastigmatix(dot)net> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>, David Fetter <david(at)fetter(dot)org>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: string_to_array, array_to_string function without separator |
| Date: | 2019-03-15 16:31:21 |
| Message-ID: | 64cde08f-133c-d2c4-3874-ca4e79962c07@anastigmatix.net |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 3/15/19 12:15 PM, Tom Lane wrote:
> Chapman Flack <chap(at)anastigmatix(dot)net> writes:
>> So the proposal seems roughly equivalent to making string_to_array's
>> second parameter optional default null, and array_to_string's second
>> parameter optional default ''.
>
> In that case why bother? It'll just create a cross-version compatibility
> hazard for next-to-no keystroke savings. If the cases were so common
> that they could be argued to be sane "default" behavior, I might feel
> differently --- but if you were asked in a vacuum what the default
> delimiters ought to be, I don't think you'd say "no delimiter".
One could go further and argue that the non-optional arguments improve
clarity: a reader seeing the explicit NULL or '' argument gets a strong
clue what's intended, who in the optional-argument case might end up
thinking "must go look up what this function's default delimiter is".
-Chap
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2019-03-15 16:36:39 | Re: [HACKERS] EvalPlanQual behaves oddly for FDW queries involving system columns |
| Previous Message | Tom Lane | 2019-03-15 16:27:45 | Re: GTIN14 support for contrib/isn |