Re: [GENERAL] Server process crash - Segmentation fault

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Adrian Klaver <adrian(dot)klaver(at)aklaver(dot)com>
Cc: Leif Jensen <leif(at)crysberg(dot)dk>, pgsql-general <pgsql-general(at)postgresql(dot)org>, pgsql-bugs(at)postgresql(dot)org
Subject: Re: [GENERAL] Server process crash - Segmentation fault
Date: 2014-05-08 14:43:37
Message-ID: 6499.1399560217@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs pgsql-general

Adrian Klaver <adrian(dot)klaver(at)aklaver(dot)com> writes:
> On 05/08/2014 07:19 AM, Tom Lane wrote:
>> 9.3 patch is here:
>> http://git.postgresql.org/gitweb/?p=postgresql.git;a=commitdiff;h=fc58c39d468587467c7c55b349c28167794eadaf

> Alright, so I obviously linked to the wrong patch because I pointed at
> HEAD and not REL9_3_STABLE.

I think those patches are the same, actually, but I was trying to be
careful.

> What I am trying to figure out is what is
> the distinction between commit and commitdiff?

The "commitdiff" link shows you the actual diffs in the patch, the other
one doesn't.

In practice, Leif's going to want to hit the "patch" link anyway to get a
clean downloadable patch; so likely what we should have pointed him at is
http://git.postgresql.org/gitweb/?p=postgresql.git;a=patch;h=fc58c39d468587467c7c55b349c28167794eadaf
I'm just in the habit of looking at the "commitdiff" versions of the web
pages as being the best readability/information tradeoff for casual
examination of a patch.

regards, tom lane

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message Adrian Klaver 2014-05-08 14:49:25 Re: Server process crash - Segmentation fault
Previous Message Adrian Klaver 2014-05-08 14:34:25 Re: [GENERAL] Server process crash - Segmentation fault

Browse pgsql-general by date

  From Date Subject
Next Message Adrian Klaver 2014-05-08 14:49:25 Re: Server process crash - Segmentation fault
Previous Message Adrian Klaver 2014-05-08 14:34:25 Re: [GENERAL] Server process crash - Segmentation fault