| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Heikki Linnakangas <hlinnaka(at)iki(dot)fi> |
| Cc: | pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: [COMMITTERS] pgsql: Use static inline functions for float <-> Datum conversions. |
| Date: | 2016-08-31 17:48:18 |
| Message-ID: | 6493.1472665698@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
Heikki Linnakangas <hlinnaka(at)iki(dot)fi> writes:
> On 08/31/2016 08:27 PM, Tom Lane wrote:
>> We had a bunch of similar problems in the recent work on exact degree trig
>> functions, and eventually found that storing values into volatile float8
>> variables was the most reliable way to force rounding to the expected
>> storage width. I propose to replace the above hack with declaring
>> newelemorder as volatile, and see if that makes things better.
> Sounds reasonable. None of this is supposed to be necessary, we're just
> working around broken compilers, so whatever works.
> I'll prepare a patch for that tomorrow, unless you're on it already.
On it already.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2016-08-31 17:58:06 | pgsql: Try to fix portability issue in enum renumbering (again). |
| Previous Message | Heikki Linnakangas | 2016-08-31 17:42:58 | Re: [COMMITTERS] pgsql: Use static inline functions for float <-> Datum conversions. |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2016-08-31 17:59:48 | Re: pg_sequence catalog |
| Previous Message | Peter Geoghegan | 2016-08-31 17:46:18 | Re: ICU integration |