Re: pgsql: Make PostgreSQL::Test::Cluster compatible with all live branches

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Andrew Dunstan <andrew(at)dunslane(dot)net>
Cc: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: Make PostgreSQL::Test::Cluster compatible with all live branches
Date: 2022-03-31 16:50:41
Message-ID: 648533.1648745441@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Andrew Dunstan <andrew(at)dunslane(dot)net> writes:
> There are three ways out of this that I can see:
> . carry a copy of parent.pm in src/test/perl (It's very small)
> . use the older and heavier 'base' module which goes back to 5.004, and
> does much the same thing (and a lot more)
> . just do directly what parent.pm's import() does, as in the attached,
> which I have tested down to version 10.

> On the whole I think I prefer the last.

I like #3 too, given that it's such a small patch. I've verified
that it allows regression tests to run on perl 5.8.8, which is the
oldest I have handy other than prairiedog's 5.8.3 (but that machine
is tied up and I don't feel like trying to test this concurrently
with a buildfarm run).

regards, tom lane

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Robert Haas 2022-03-31 16:56:31 Re: pgsql: Add 'basebackup_to_shell' contrib module.
Previous Message Tom Lane 2022-03-31 16:45:13 Re: pgsql: Add 'basebackup_to_shell' contrib module.