Re: Quoting of psql \d output

Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> psql \d always double-quotes table names:
> Table "public.xx"

Yeah, that has bugged me for a while, because it is in fact *wrong* ...
the above representation of a qualified name is incorrect.

> This patch uses pg_dump fmtId() to double-quote only when necessary.

Seems good, but I think your Makefile patch is a brick or two shy of
a load. Don't you need something to make sure that parser/keywords.o
is up to date?

More generally, maybe we ought to think about moving fmtId() and perhaps
other parts of dumputils out of pg_dump and into some
more-easily-accessible library.

regards, tom lane