From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | Andrew Gierth <andrew(at)tao11(dot)riddles(dot)org(dot)uk> |
Cc: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, pgsql-hackers(at)postgresql(dot)org, Andres Freund <andres(at)anarazel(dot)de> |
Subject: | Re: Should contrib modules install .h files? |
Date: | 2018-07-02 20:46:04 |
Message-ID: | 64174.1530564364@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Andrew Gierth <andrew(at)tao11(dot)riddles(dot)org(dot)uk> writes:
> Two questions arise:
> 1) include/server has a lot of files and subdirs, so using
> include/server/$(MODULE)/ looks likely to be error-prone. So it
> should be something like include/server/contrib/$(MODULE)/ or
> include/server/extension/$(MODULE)/. Which one, or should it use
> $(MODULEDIR) to choose between the two the way that DATA and DOCS do?
> Or something else?
Might as well follow the MODULEDIR precedent (though I'm not wedded
to that if somebody has an argument for something else).
> 2) Specifying HEADERS_blah for some name "blah" that's not listed in
> MODULES or MODULE_big should do what:
> a) install into blah/ anyway
> b) be ignored with a warning
> c) be silently ignored
> d) be an error
I'd definitely vote for "error". Likewise if any .h file listed in
the macro doesn't exist.
regards, tom lane
From | Date | Subject | |
---|---|---|---|
Next Message | Andrew Gierth | 2018-07-02 21:05:27 | Re: Should contrib modules install .h files? |
Previous Message | Andrew Gierth | 2018-07-02 20:27:42 | Re: Should contrib modules install .h files? |