Re: Add docs stub for recovery.conf

From: "Euler Taveira" <euler(at)eulerto(dot)com>
To: "Stephen Frost" <sfrost(at)snowman(dot)net>, "Craig Ringer" <craig(dot)ringer(at)enterprisedb(dot)com>
Cc: "Bruce Momjian" <bruce(at)momjian(dot)us>, "Isaac Morland" <isaac(dot)morland(at)gmail(dot)com>, "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Add docs stub for recovery.conf
Date: 2021-03-28 19:55:59
Message-ID: 63df2678-1177-4a91-9d87-738b8e4abc51@www.fastmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sun, Mar 28, 2021, at 2:22 PM, Stephen Frost wrote:
> Unless there's anything further, will commit these soon.
I briefly looked at this patch and have a few comments.

+<sect1 id="app-pgreceivexlog" xreflabel="pg_receivexlog">
+ <title><command>pg_receivexlog</command> renamed to <command>pg_recievewal</command></title>

s/pg_recievewal/pg_receivewal/

+<appendix id="appendix-obsolete">
+ <title>Obsolete or renamed features, settings and files</title>

Section titles are capitalized so it should be "Obsolete or Renamed Features,
Settings and Files". I find this section name too descriptive. I didn't follow
this thread but maybe we might use a generic name that is also shorter than it
such as "Incompatible or Obsolete Features".

+ <primary>trigger_file</primary>
+ <see>promote_trigger_file</see>
+ </indexterm>
+ setting has been renamed to
+ <xref linkend="guc-promote-trigger-file"/>
+ </para>

There should be a period after the <xref>.

--
Euler Taveira
EDB https://www.enterprisedb.com/

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Vik Fearing 2021-03-28 20:43:30 Re: Idea: Avoid JOINs by using path expressions to follow FKs
Previous Message Bernd Helmle 2021-03-28 17:39:25 Re: postgres_fdw: IMPORT FOREIGN SCHEMA ... LIMIT TO (partition)