Re: Add on_error and log_verbosity options to file_fdw

On 2024-09-25 00:46, Fujii Masao wrote:
Thanks for the comments!

> On 2024/09/24 20:08, torikoshia wrote:
>> Thanks for the explanation and suggestion.
>> Since there is almost the same code in copyfrom.c, attached 0003 patch
>> for refactoring both.
>
> Thanks for updating the patches!
>
> Regarding 0002.patch, I think it’s better to include the refactored
> code
> from the start rather than adding redundant code intentionally.
> How about leaving just the refactor in copyfrom.c to 0003.patch?
> If that works, as a refactoring, you could also replace "skipped" with
> "cstate->num_errors" in that patch, as you suggested earlier.

Agreed.

> While reviewing again, I noticed that running ANALYZE on a file_fdw
> foreign table also calls NextCopyFrom(), but it doesn’t seem to
> skip erroneous rows when on_error is set to "ignore." This could lead
> to inaccurate statistics. Shouldn’t ANALYZE on file_fdw foreign tables
> with on_error=ignore also skip erroneous rows?

Thanks, it seems the right thing to do.

>>> The tab-completion needs to be updated to support the "silent"
>>> option?
>>
>> Yes, updated 0002 patch.
>
> Thanks! Also, this should be part of 0001.patch since "silent" is
> introduced there, right?

Agreed.

Updated the patches.

--
Regards,

--
Atsushi Torikoshi
NTT DATA Group Corporation