Re: array_cat anycompatible change is breaking xversion upgrade tests

From: Andrey Borodin <x4mmm(at)yandex-team(dot)ru>
To: Justin Pryzby <pryzby(at)telsasoft(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Andrew Dunstan <andrew(at)dunslane(dot)net>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Bruce Momjian <bruce(at)momjian(dot)us>
Subject: Re: array_cat anycompatible change is breaking xversion upgrade tests
Date: 2022-06-24 12:46:19
Message-ID: 637BA1CB-20DA-4C95-BEF1-CBF0C393C1E1@yandex-team.ru
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> On 24 Jun 2022, at 16:09, Andrey Borodin <x4mmm(at)yandex-team(dot)ru> wrote:
>
> Would it be backpatchable to add this check to pg_upgrade?

Just to be clear of what exactly I propose I drafted a patch. PFA.
I've tested it with PG13 and
CREATE AGGREGATE public.array_accum(anyelement) (
SFUNC = array_append,
STYPE = anyarray,
INITCOND = '{}',
PARALLEL = safe
);
CREATE OPERATOR ##% (leftarg=anyarray, rightarg=anyelement,function=array_append);

Operator output currently look a bit strage, but does it's job. pg_upgrade_output.d/operators.txt:
In database: postgres
(oid=16385) ##% in public

Thanks!

Best regards, Andrey Borodin.

Attachment Content-Type Size
v1-0001-Check-incompatible-aggreagtes-and-operators-befor.patch application/octet-stream 9.3 KB

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Drouvot, Bertrand 2022-06-24 12:47:50 Re: SYSTEM_USER reserved word implementation
Previous Message Aleksander Alekseev 2022-06-24 12:30:31 Re: CREATE TABLE ( .. STORAGE ..)