Re: "serializable" in comments and names

"Kevin Grittner" <Kevin(dot)Grittner(at)wicourts(dot)gov> writes:
> Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
>> XactUsesPerXactSnapshot()?

> That seems unambiguous. I think I prefer it to
> IsXactIsoLevelXactSnapshotBased, so if there are no objections, I'll
> switch to XactUsesPerXactSnapshot. The current code uses a macro
> without parentheses; are you suggesting that the new code add those?

+1 for adding parens; we might want to make a function of it someday.

> Names starting with IsXactIsoLevel seem more technically correct,
> but the names get long enough that it seems to me that the meaning
> gets a bit lost in the jumble of words -- which is why I like the
> shorter suggested name. Any other opinions out there?

I don't much like the "XactUses..." aspect of it; that's just about
meaningless, because almost everything in PG could be said to be "used"
by a transaction. How about IsolationUsesXactSnapshot (versus
IsolationUsesStmtSnapshot)?

regards, tom lane