Re: Proposal: More structured logging

From: Ronan Dunklau <ronan(dot)dunklau(at)aiven(dot)io>
To: Julien Rouhaud <rjuju123(at)gmail(dot)com>
Cc: Justin Pryzby <pryzby(at)telsasoft(dot)com>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: Proposal: More structured logging
Date: 2022-01-18 05:46:03
Message-ID: 6362106.lOV4Wx5bFT@aivenronan
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Le lundi 17 janvier 2022, 09:18:04 CET Ronan Dunklau a écrit :
> Le samedi 15 janvier 2022, 07:09:59 CET Julien Rouhaud a écrit :
> > Hi,
> >
> > On Tue, Jan 11, 2022 at 11:05:26AM +0100, Ronan Dunklau wrote:
> > > Done, and I added anoher commit per your suggestion to add this comment.
> >
> > The cfbot reports that the patchset doesn't apply anymore:
> >
> > http://cfbot.cputube.org/patch_36_3293.log
> > === Applying patches on top of PostgreSQL commit ID
> > 43c2175121c829c8591fc5117b725f1f22bfb670 === [...]
> > === applying patch ./v4-0003-Output-error-tags-in-CSV-logs.patch
> > [...]
> > patching file src/backend/utils/error/elog.c
> > Hunk #2 FAILED at 3014.
> > 1 out of 2 hunks FAILED -- saving rejects to file
> > src/backend/utils/error/elog.c.rej
> >
> > Could you send a rebased version? In the meantime I will switch the cf
> > entry to Waiting on Author.
>
> Thank you for this notification !
>
> The csvlog has been refactored since I wrote the patch, and the new jsonlog
> destination has been introduced. I rebased to fix the first patch, and added
> a new patch to add support for tags in jsonlog output.
>
> Best regards,

Hum, there was a missing import in csvlog.c from the fix above. Sorry about
that.

--
Ronan Dunklau

Attachment Content-Type Size
v6-0001-Add-ErrorTag-support.patch text/x-patch 4.0 KB
v6-0002-Add-test-module-for-the-new-tag-functionality.patch text/x-patch 6.6 KB
v6-0003-Output-error-tags-in-CSV-logs.patch text/x-patch 1.5 KB
v6-0004-Add-comment-in-config.sgml-as-a-reminder-to-also-.patch text/x-patch 889 bytes
v6-0005-Add-error-tags-to-json-output.patch text/x-patch 1.3 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Corey Huinker 2022-01-18 06:02:17 Re: Push down time-related SQLValue functions to foreign server
Previous Message Tom Lane 2022-01-18 05:43:58 Re: Push down time-related SQLValue functions to foreign server