| From: | Peter Eisentraut <peter(at)eisentraut(dot)org> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: ecpg_config.h symbol missing with meson |
| Date: | 2024-04-24 06:32:26 |
| Message-ID: | 634557bd-ac58-4c5d-8feb-e1ef0271c005@eisentraut.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 17.04.24 18:15, Tom Lane wrote:
> Peter Eisentraut <peter(at)eisentraut(dot)org> writes:
>> I checked the generated ecpg_config.h with make and meson, and the meson
>> one is missing
>
>> #define HAVE_LONG_LONG_INT 1
>
>> This is obviously quite uninteresting, since that is required by C99.
>> But it would be more satisfactory if we didn't have discrepancies like
>> that. Note that we also kept ENABLE_THREAD_SAFETY in ecpg_config.h for
>> compatibility.
>> ...
>> Alternatively, we could remove the symbol from the make side.
>
> Think I'd vote for removing it, since we use it nowhere.
> The ENABLE_THREAD_SAFETY precedent feels a little bit different,
> since there's not the C99-requires-the-feature angle.
Ok, fixed by removing instead.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Yugo NAGATA | 2024-04-24 06:32:33 | Re: Extend ALTER DEFAULT PRIVILEGES for large objects |
| Previous Message | Amit Kapila | 2024-04-24 06:29:22 | Re: Race condition in FetchTableStates() breaks synchronization of subscription tables |