Re: New "raw" COPY format

On Thu, Oct 24, 2024, at 03:54, Masahiko Sawada wrote:
> I have one question:
>
> From the 0001 patch's commit message:
>
> No behavioral changes are intended; this is a pure refactoring to improve code
> clarity and maintainability.
>
> Does the reorganization of the option validation done by this patch
> also help make the 0002 patch simple or small?

Thanks for the review. No, not much, except the changes necessary to
ProcessCopyOptions for raw, without also refactoring it, makes it
more complicated.

> If not much, while it
> makes sense to me that introducing the CopyFormat enum is required by
> the 0002 patch, I think we can discuss the reorganization part
> separately. And I'd suggest the patch organization would be:
>
> 0001: introduce CopyFormat and replace csv_mode and binary fields with it.
> 0002: add new 'raw' format.
> 0003: reorganize option validations.
>
> One benefit would be that we can remove the simple replacements like
> '->binary' with '.format == COPY_FORMAT_BINARY' from the
> reorganization patch, which makes it small. The 0001 and 0002 patches
> that seem to be more straightforward are independent from the 0003
> patch, and we can discuss how to make the option validations including
> the new 'raw' format better.

Sure, that works for me.

I've attached patches organized like that.

/Joel