| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: safer node casting |
| Date: | 2017-02-24 15:54:29 |
| Message-ID: | 6303.1487951669@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Andres Freund <andres(at)anarazel(dot)de> writes:
> Those aren't actually equivalent, because of the !nodeptr. IsA() crashes
> for NULL pointers, but the new code won't. Which means 9ba8a9ce4548b et
> al actually weakened some asserts.
> Should we perhaps have one NULL accepting version (castNodeNull?) and
> one that separately asserts that ptr != NULL?
-1 ... if you're going to use something in a way that requires it not to
be null, your code will crash quite efficiently on a null, with or
without an assert. I don't think we need the extra cogitive burden of
two distinct macros for this.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2017-02-24 16:02:54 | Re: btree_gin and btree_gist for enums |
| Previous Message | Dilip Kumar | 2017-02-24 15:45:50 | Re: utility commands benefiting from parallel plan |