| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Dong Wook Lee <sh95119(at)gmail(dot)com> |
| Cc: | pgsql-hackers(at)postgresql(dot)org, stephen(dot)frost(at)crunchydata(dot)com, reid(dot)thompson(at)crunchydata(dot)com |
| Subject: | Re: pg_buffercache: add sql test |
| Date: | 2022-07-30 19:39:38 |
| Message-ID: | 628172.1659209978@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Dong Wook Lee <sh95119(at)gmail(dot)com> writes:
> I just wrote a test code for the `pg_buffercache` extension which
> doesn't not have test code.
Pushed with minor adjustments. Some notes:
* A .gitignore file is needed so that "git status" won't whine after
running the test. This tends to be pretty much boilerplate; I copied
it from another contrib directory.
* Pay attention to "git diff --check" formatting warnings. In this
case it bleated about an extra blank line at the end of the .sql file.
* I didn't care for the direct use of pg_show_all_settings(). The
official API there is the pg_settings view, and there's no need for
this test to get friendly with the view's internals.
Thanks for the patch!
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2022-07-30 20:33:33 | Re: Trying to add more tests to gistbuild.c |
| Previous Message | Matheus Alcantara | 2022-07-30 18:55:51 | Re: Trying to add more tests to gistbuild.c |