Re: Further simplification of c.h's #include section

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Further simplification of c.h's #include section
Date: 2017-11-15 21:46:19
Message-ID: 6279.1510782379@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Robert Haas <robertmhaas(at)gmail(dot)com> writes:
> On Wed, Nov 15, 2017 at 4:32 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> How do you feel about "win32_more.h"?

> Seems morally equivalent to what you had before. I think what I would
> be looking for is a filename that somehow conveys what the difference
> is between what should go in the existing file and what should go in
> the new file. If we don't know, maybe we should find out before we
> change things.

Well, the point is whether it gets included before or after the key
system header files. "win32_post_headers.h", perhaps?

As for the question of what actually needs to be in it, you're
asking the wrong person. It looks like some of it could be moved
to before the system headers, but I am in no position to find out
exactly what, except by trial-and-error with the buildfarm. And
TBH I don't care particularly, as long as it's in a windows-specific
file and not a common file.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2017-11-15 21:51:42 Re: Updated macOS start scripts
Previous Message Peter Eisentraut 2017-11-15 21:42:35 Re: [HACKERS] Transaction control in procedures