Re: VACUUM (DISABLE_PAGE_SKIPPING on)

On 4/8/21 12:29 PM, Simon Riggs wrote:
> On Thu, 8 Apr 2021 at 16:58, David Steele <david(at)pgmasters(dot)net> wrote:
>
>>>> It has been five months since this patch was updated, so marking
>>>> Returned with Feedback.
>>>>
>>>> Please resubmit to the next CF when you have a new patch.
>>>
>>> There are 2 separate patch-sets on this thread, with separate CF entries.
>>>
>>> One has requested changes that have not been made. I presume this one
>>> has been RwF'd.
>>>
>>> What is happening about the other patch?
>>
>> Hmmm, well https://commitfest.postgresql.org/32/2908 and
>> https://commitfest.postgresql.org/32/2909 are both linked to the same
>> thread with the same patch, so I thought it was a duplicate.
>
> Nobody had mentioned any confusion. Multiple patches on one thread is common.

Yes, but these days they generally get updated in the same reply so the
cfbot can test them all. In your case only the latest patch was being
tested and it was not applying cleanly.

>> It's not clear to me which patch is which, so perhaps move one CF entry
>> to next CF and clarify which patch is current?
>
> Entry: Maximize page freezing
> has this patch, perfectly fine, awaiting review from Alvaro since 29 Nov.
> one_freeze_then_max_freeze.v7.patch

That CF entry was marked Waiting for Author on 3/11, so I thought it was
for this patch. In fact, both CF entries were Waiting for Author for
some time.

Moved to the next CF in Waiting for Author state.

Regards,
--
-David
david(at)pgmasters(dot)net