Whether to back-patch fix for aggregate transtype width estimates

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-hackers(at)postgreSQL(dot)org
Subject: Whether to back-patch fix for aggregate transtype width estimates
Date: 2016-06-18 02:41:53
Message-ID: 6221.1466217713@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

While fixing the recent unpleasantness over parallel polymorphic
aggregates, I discovered that count_agg_clauses_walker's consideration
of an aggregate argument's typmod in estimating transition space
consumption has been broken since commit 34d26872e (which changed
Aggref.args from a simple expression list to a list of TargetEntry).
It had been looking at "exprTypmod((Node *) linitial(aggref->args))",
and nobody taught it that there was now a TargetEntry in the way that
it needed to look through to get a correct answer.

Ordinarily I'd just summarily back-patch a fix, but that commit shipped
in 9.0, which means it's been broken a long time. I'm worried that
back-patching a change might be more likely to destabilize plan choices
than to do anything anybody's happy about.

Thoughts?

regards, tom lane

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Amit Kapila 2016-06-18 03:16:23 Re: pgsql: Try again to fix the way the scanjoin_target is used with partia
Previous Message Amit Kapila 2016-06-18 02:14:49 Re: pgsql: Try again to fix the way the scanjoin_target is used with partia