| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)commandprompt(dot)com> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: "Bogus data in lock file" shouldn't be FATAL? |
| Date: | 2010-08-16 16:12:53 |
| Message-ID: | 6217.1281975173@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Alvaro Herrera <alvherre(at)commandprompt(dot)com> writes:
> Excerpts from Tom Lane's message of lun ago 16 11:49:51 -0400 2010:
>> The bottom line here is that it's not clear to me whether changing this
>> would be a net reliability improvement or not. Maybe better to leave
>> it alone.
> In that case, maybe consider fsync'ing it.
Hrm ... I had supposed we did fsync lockfiles, but a look at the code
shows not. This seems like a clear oversight. I think we should not
only add that, but back-patch it. It seems entirely plausible that the
lack of an fsync is exactly what led to the original complaint.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2010-08-16 16:21:03 | Re: refactoring comment.c |
| Previous Message | Tom Lane | 2010-08-16 16:08:42 | Re: Conflicted names of error conditions. |