| From: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
|---|---|
| To: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Justin Pryzby <pryzby(at)telsasoft(dot)com> |
| Cc: | Dilip Kumar <dilipbalaut(at)gmail(dot)com>, Julien Rouhaud <rjuju123(at)gmail(dot)com>, Kuntal Ghosh <kuntalghosh(dot)2007(at)gmail(dot)com>, Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com>, Kirill Bychik <kirill(dot)bychik(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com> |
| Subject: | Re: WAL usage calculation patch |
| Date: | 2020-04-07 10:00:29 |
| Message-ID: | 61b66de7-ebb3-fada-b6d3-243386976631@2ndquadrant.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2020-04-07 04:12, Amit Kapila wrote:
> On Mon, Apr 6, 2020 at 10:01 PM Justin Pryzby <pryzby(at)telsasoft(dot)com> wrote:
>>
>> On Mon, Apr 06, 2020 at 05:01:30PM +0200, Peter Eisentraut wrote:
>>> I noticed in some of the screenshots that were tweeted that for example in
>>>
>>> WAL: records=1 bytes=56
>>>
>>> there are two spaces between pieces of data. This doesn't match the rest of
>>> the EXPLAIN output. Can that be adjusted?
>>
>> We talked about that here:
>> https://www.postgresql.org/message-id/20200402054120.GC14618%40telsasoft.com
>>
>
> Yeah. Just to brief here, the main reason was that one of the fields
> (full page writes) already had a single space and then we had prior
> cases as mentioned in Justin's email [1] where we use two spaces which
> lead us to decide using two spaces in this case.
We also have existing cases for the other way:
actual time=0.050..0.052
Buffers: shared hit=3 dirtied=1
The cases mentioned by Justin are not formatted in a key=value format,
so it's not quite the same, but it also raises the question why they are
not.
Let's figure out a way to consolidate this without making up a third format.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Prabhat Sahu | 2020-04-07 10:22:12 | Re: [Proposal] Global temporary tables |
| Previous Message | Amit Kapila | 2020-04-07 09:58:39 | Re: [HACKERS] make async slave to wait for lsn to be replayed |