From: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
---|---|
To: | Jelte Fennema-Nio <postgres(at)jeltef(dot)nl>, Daniel Gustafsson <daniel(at)yesql(dot)se> |
Cc: | Tristan Partin <tristan(at)neon(dot)tech>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Euler Taveira <euler(at)eulerto(dot)com>, Michael Banck <mbanck(at)gmx(dot)net>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Add --check option to pgindent |
Date: | 2023-12-19 13:51:41 |
Message-ID: | 61b30eea-cd41-d67b-82eb-48a340a00af1@dunslane.net |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On 2023-12-18 Mo 11:14, Jelte Fennema-Nio wrote:
> On Mon, 18 Dec 2023 at 13:42, Daniel Gustafsson <daniel(at)yesql(dot)se> wrote:
>> I think this is pretty much ready to go, the attached v4 squashes the changes
>> and fixes the man-page which also needed an update. The referenced Wiki page
>> will need an edit or two after this goes in, but that's easy enough.
> One thing I'm wondering: When both --check and --diff are passed,
> should pgindent still early exit with 2 on the first incorrectly
> formatted file? Or should it show diffs for all failing files? I'm
> leaning towards the latter making more sense.
It should show them all.
>
> Related (but not required for this patch): For my pre-commit hook I
> would very much like it if there was an option to have pgindent write
> the changes to disk, but still exit non-zero, e.g. a --write flag that
> could be combined with --check just like --diff and --check can be
> combined with this patch. Currently my pre-commit hook need two
> separate calls to pgindent to both abort the commit and write the
> required changes to disk.
Not sold on this. I don't want pgindent applied automatically to my
uncommitted changes, but I do want a reminder that I forgot to run it.
In any case, as you say it's a different topic.
cheers
andrew
--
Andrew Dunstan
EDB: https://www.enterprisedb.com
From | Date | Subject | |
---|---|---|---|
Next Message | Daniel Gustafsson | 2023-12-19 13:57:58 | Re: Add --check option to pgindent |
Previous Message | Karina Litskevich | 2023-12-19 13:48:14 | Correct the documentation of extension building infrastructure |